Locales can't be found on ESM module and CodeSandbox

❔ Question

Hi

I just made the upgrade from the previous version. So, I replace the locale import by a reference to locale into the tag definition (as following):
<SemanticDatepicker selected={oDateRange} type="range" showOutsideDays locale="fr-FR"...>

The build step (based on rollup) runs correctly, but the execution fails with the following error:
ReferenceError: "require is not defined"
More specifically, at: react-semantic-ui-datepickers.esm.js:1084.

I import a lot of esm files, withount encounter this issue. Moreover, according the rollup configuration, it seems the locales files must be embedded into the distribution files. But, it seems do not be the case.

Has I missed some thing ?

Thanks in advance

Fred

[arthurdenner]

Hi @Fred2MTL! 👋

The locales folder is published as you can see on unpkg.

However, I've tried to create an example on CodeSandbox and it's displaying only the en-US.json file and I don't understand why. 🤔

Regarding your error, require is not defined, I'm not sure what could be the issue as this works on Storybook locally and on the website. 😕

@arthurdenner

I understand 'require' in this context as a loading command specific to the node context, not to the library. Beacause:

• it references a static path, starting from the '.' (aka current directory),
• being included in all produced libraries (esm, gjs, etc.), it's not specific to the esm context.

So, in my undestanding, it must be resolved at the build time (e.g by rollup) by including the locales directory into the distributed library. Moreover, assuming it forces the locales files to be in this directory, it could not be extended at the design time / the runtime by providing another locales structure.

Concerning the storybook point and without deep knowledge, I think the code is run on the server side (e.g. into a node context), explaining the effective load of locales by node, prior to any transformations into Httml / JS, not the client side.

Fred

[arthurdenner]

But the locales folder is in the dist folder as you can see in unpkg link. I'm going to tag this and feel free to work on it if you want, I'm quite busy with a personal project at the moment and can't promise to look at it soon.

Hi @arthurdenner
I rollback to the previous version and wait for your availability.
Thanks in advance
Fred

[arthurdenner]

I would say that is better if you try to contribute than wait for me :)

[arthurdenner]

@Fred2MTL, could you provide a reproducible repo with instructions regarding this? It's important for whoever is going to work on it.

@arthurdenner
No problem. I will do that this week.

[arthurdenner]

@Fred2MTL, any updates?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.