Skip to content

Add vat alias so stdnum.vatin works for the United States #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

unho
Copy link
Contributor

@unho unho commented Sep 10, 2022

While stdnum provides several modules implementing some sort of TIN for the United States, EIN is the only only used for companies and institutions.

While stdnum provides several modules implementing some sort of TIN for the
United States, EIN is the only only used for companies and institutions.
@arthurdejong
Copy link
Owner

I'm pretty sure the US does not have the concept of VAT but they have sales tax instead: https://en.wikipedia.org/wiki/Value-added_tax#United_States

Closing this for now. We may want to introduce something along the lines of validation of any valid TIN but that can get complicated pretty fast and which kind of identifiers are appropriate is most likely very application-dependant.

@unho
Copy link
Contributor Author

unho commented Apr 30, 2023

@arthurdejong The validation of any valid TIN is provided by stdnum.vatin module, which relies on these vat aliases. So this PR was just adding this tiny change to make sure these module was able to validate TIN numbers for the United States.

If you prefer we can instead use a different alias, but then we will have to review all the countries to untagle the VAT number and TIN number, if that is even possible. Not to mention that this will break third party software like Odoo.

@unho unho mentioned this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants