Skip to content

Commit

Permalink
fix: Fixes website slot Private Endpoint configuration (Azure#926)
Browse files Browse the repository at this point in the history
## Description

Closes Azure#925 

## Pipeline


[![avm.res.web.site](https://github.com/tyconsulting/bicep-registry-modules/actions/workflows/avm.res.web.site.yml/badge.svg?branch=users%2Ftao%2F925_website)](https://github.com/tyconsulting/bicep-registry-modules/actions/workflows/avm.res.web.site.yml)

## Adding a new module

<!--Run through the checklist if your PR adds a new module.-->

- [ ] A proposal has been submitted and approved.
- [ ] I have included "Closes #{module_proposal_issue_number}" in the PR
description.
- [ ] I have run `brm validate` locally to verify the module files.
- [ ] I have run deployment tests locally to ensure the module is
deployable.

## Updating an existing module

<!--Run through the checklist if your PR updates an existing module.-->

- [x] This is a bug fix:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.
- [ ] I have read the [Updating an existing
module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module)
section in the contributing guide and updated the `version.json` file
properly:
- [x] The PR contains backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`.
- [ ] The PR contains backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] The PR contains breaking changes, and I have bumped the MAJOR
version in `version.json`.
- [ ] I have updated the examples in README with the latest module
version number.

Co-authored-by: ChrisSidebotham-MSFT <48600046+ChrisSidebotham@users.noreply.github.com>
Co-authored-by: Buddy <38195643+tsc-buddy@users.noreply.github.com>
  • Loading branch information
3 people authored Feb 14, 2024
1 parent 0f8f5dd commit 6899f44
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion avm/res/web/site/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ module app_slots 'slot/main.bicep' = [for (slot, index) in (slots ?? []): {
appSettingsKeyValuePairs: slot.?appSettingsKeyValuePairs ?? appSettingsKeyValuePairs
basicPublishingCredentialsPolicies: slot.?basicPublishingCredentialsPolicies ?? basicPublishingCredentialsPolicies
lock: slot.?lock ?? lock
privateEndpoints: slot.?privateEndpoints ?? privateEndpoints
privateEndpoints: slot.?privateEndpoints ?? []
tags: slot.?tags ?? tags
clientCertEnabled: slot.?clientCertEnabled
clientCertExclusionPaths: slot.?clientCertExclusionPaths
Expand Down
4 changes: 2 additions & 2 deletions avm/res/web/site/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.24.24.22086",
"templateHash": "6827854649814438473"
"templateHash": "10377090959004552073"
},
"name": "Web/Function Apps",
"description": "This module deploys a Web or Function App.",
Expand Down Expand Up @@ -1191,7 +1191,7 @@
"value": "[coalesce(tryGet(coalesce(parameters('slots'), createArray())[copyIndex()], 'lock'), parameters('lock'))]"
},
"privateEndpoints": {
"value": "[coalesce(tryGet(coalesce(parameters('slots'), createArray())[copyIndex()], 'privateEndpoints'), parameters('privateEndpoints'))]"
"value": "[coalesce(tryGet(coalesce(parameters('slots'), createArray())[copyIndex()], 'privateEndpoints'), createArray())]"
},
"tags": {
"value": "[coalesce(tryGet(coalesce(parameters('slots'), createArray())[copyIndex()], 'tags'), parameters('tags'))]"
Expand Down

0 comments on commit 6899f44

Please sign in to comment.