This repository has been archived by the owner on Dec 26, 2023. It is now read-only.
feature(injector): filename template #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: Customizable filename with placeholder template string @kevinchappell
arthurbergmz
approved these changes
Jan 17, 2018
|
Thank you! It will be available soon, with a couple of changes that I'll make for the next release. |
|
Excellent, thank you! |
kevinchappell
commented
Jan 18, 2018
| value: (match, limit = ':32') => { | ||
| const hash = generateFingerprint(json) | ||
| limit = hash.length - parseInt(limit.substr(1), 10) | ||
| return hash.substr(limit) |
There was a problem hiding this comment.
i made a mistake here. have opened #35 to fix it
|
@arthurbergmz would it be possible to publish a new release to have this fantastic feature? |
|
@fernandopasik Please, update to v3.5.0! |
|
@arthurbergmz, it worked great! Thanks for the hard work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: Customizable filename with placeholder template string
What it do
Provides additional customization to
manifest.jsonfilename, allowing developer to remove or customize hash (fingerprint), extension and name.Usage:
filename output