Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

Recursive output folder creation with 3.3.4 release #30

Closed
Guymestef opened this issue Dec 20, 2017 · 5 comments · Fixed by #50
Closed

Recursive output folder creation with 3.3.4 release #30

Guymestef opened this issue Dec 20, 2017 · 5 comments · Fixed by #50

Comments

@Guymestef
Copy link

Hello,

With following version of packages:
"webpack": "~3.10.0",
"webpack-hot-middleware": "~2.21.0",
"webpack-pwa-manifest": "~3.3.4"

Each time the HMR rebuild sources, a new output folder with a manifest file is created inside the normal output folder, ending up after few rebuild with something like that:

/dist/[compiled sources]
/dist/manifest.json
/dist/dist/manifest.json
/dist/dist/manifest.json
/dist/dist/dist/manifest.json
/dist/dist/dist/dist/manifest.json
/dist/dist/dist/dist/dist/manifest.json
...

Everything was fine with "webpack-pwa-manifest": "~3.3.2"

Webpack has the conf output.publicPath set to '/dist/' and output.path set to path.join(__dirname, './ClientApp/dist')
@arthurbergmz
Copy link
Owner

@Guymestef Can you show your Webpack config's plugins array, please?

@Guymestef
Copy link
Author

Sorry, I can't right now. It's from a work project and I'm off for the rest of the year... ^_^'
I don't know if it will help but the base of the project is from the react-redux template of vs2017 for aspnet core.

@arthurbergmz
Copy link
Owner

@Guymestef I need to see the WebpackPwaManifest config. Did you use the property filename in it?

@Guymestef
Copy link
Author

It's from memory, but I think I used: filename: "manifest.json"

@arthurbergmz
Copy link
Owner

@Guymestef

Please, update to v3.4.0 and add includeDirectory: false to your WebpackPwaManifest config.

Reopen this issue if it doesn't work yet.
Thank you!

satazor added a commit to satazor/webpack-pwa-manifest that referenced this issue Feb 13, 2018
@satazor
Fix recursive filename after several rebuilds in development
577f34e 
Fixes arthurbergmz#30
@satazor satazor mentioned this issue Feb 13, 2018
Merged
satazor added a commit to satazor/webpack-pwa-manifest that referenced this issue Feb 13, 2018
@satazor
Fix recursive filename after several rebuilds in development
55337f9 
Also:
- Fix svg assets not having the correct public url
- Remove debug console.logs from the code

Fixes arthurbergmz#30
satazor added a commit to satazor/webpack-pwa-manifest that referenced this issue Feb 13, 2018
@satazor
Fix recursive filename after several rebuilds in development
d0b5d39 
Also:
- Fix svg assets not having the correct public url
- Remove debug console.logs from the code

Fixes arthurbergmz#30
satazor added a commit to satazor/webpack-pwa-manifest that referenced this issue Feb 13, 2018
@satazor
Fix recursive filename after several rebuilds in development
f7830ad 
Also:
- Fix svg assets not having the correct public url
- Remove debug console.logs from the code

Fixes arthurbergmz#30
satazor added a commit to satazor/webpack-pwa-manifest that referenced this issue Feb 13, 2018
@satazor
Fix recursive filename after several rebuilds in development
15ed71f 
Also:
- Fix svg assets not having the correct public url
- Remove debug console.logs from the code

Fixes arthurbergmz#30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix recursive filename after several rebuilds in development satazor/webpack-pwa-manifest
2 participants
@Guymestef @arthurbergmz