[Feature] implement api of review (#3)

* refactor: extract healthy api

* rename User to Users model

* create reviews model

* implement review api

.eslintrc.js

@@ -16,6 +16,7 @@ const config = {
   },
   plugins: ['react', 'react-hooks'],
   rules: {
+    'global-require': 0,
     'import/no-extraneous-dependencies': [
       'error',
       {
@@ -27,7 +28,9 @@ const config = {
       },
     ],
     'import/prefer-default-export': 0,
+    'no-continue': 0,
     'no-else-return': 0,
+    'no-plusplus': 0,
     'react/jsx-filename-extension': [1, { extensions: ['.js', '.jsx'] }],
     'react/jsx-wrap-multilines': [
       'error',

internals/jest/globalSetup.js

@@ -1,3 +1,6 @@
-module.exports = () => {
-  require('../../server'); // eslint-disable-line global-require
+module.exports = async () => {
+  /**
+   * Start server for api test
+   */
+  require('../../server');
 };

internals/jest/globalTeardown.js

@@ -1,5 +1,10 @@
-const server = require('../../server');
+module.exports = async () => {
+  const server = require('../../server');
+  const db = require('../../server/db/models');
 
-module.exports = () => {
+  // Close db connections
+  await db.sequelize.close();
+
+  // Shutdown server
   server.close();
 };

package.json

@@ -12,7 +12,7 @@
     "prebuild": "yarn run build:clean",
     "build": "cross-env NODE_ENV=production webpack --config ./internals/webpack/prod.config.js",
     "build:clean": "rimraf ./build",
-    "test": "cross-env NODE_ENV=test jest --config ./internals/jest/config.js --passWithNoTests",
+    "test": "cross-env NODE_ENV=test jest --config ./internals/jest/config.js --passWithNoTests --runInBand",
     "test:coverage": "yarn run test --coverage",
     "test:watch": "yarn run test --watch",
     "lint": "yarn run lint-eslint .",
@@ -41,6 +41,7 @@
     "react-router-dom": "~5.0.1",
     "sequelize": "~5.19.2",
     "styled-components": "~4.3.2",
+    "uuid": "~3.3.3",
     "webpack-hot-middleware": "~2.25.0"
   },
   "devDependencies": {

server/api/__tests__/me.test.js

@@ -0,0 +1,78 @@
+const { users, reviews } = require('../../db/mockData');
+const { initMockData, getCookieByUser } = require('./utils');
+
+const api = global.createApi('/api/v1/me');
+
+const currentUser = users[0];
+
+beforeAll(async () => {
+  /**
+   * Create data for test
+   */
+  await initMockData();
+
+  /**
+   * Get cookies
+   */
+  currentUser.cookie = await getCookieByUser(currentUser);
+});
+
+describe('get me', () => {
+  it('should succeed', async () => {
+    const { status, data } = await api.get('/', {
+      headers: {
+        Cookie: currentUser.cookie,
+      },
+    });
+
+    expect(status).toBe(200);
+    expect(data.data).toMatchObject({
+      id: currentUser.id,
+      email: currentUser.email,
+    });
+  });
+});
+
+describe('get requiring reviews', () => {
+  it('should succeed', async () => {
+    const requiringReviews = reviews
+      .filter(review => review.reviewerId === currentUser.id)
+      .map(({ reviewerId, revieweeId, ...review }) =>
+        expect.objectContaining({
+          ...review,
+          reviewee: users.find(user => user.id === revieweeId).email,
+        })
+      );
+
+    const { status, data } = await api.get('/requiringReviews', {
+      headers: {
+        Cookie: currentUser.cookie,
+      },
+    });
+
+    expect(status).toBe(200);
+    expect(data.data).toEqual(expect.arrayContaining(requiringReviews));
+  });
+});
+
+describe('get feedbacks', () => {
+  it('should succeed', async () => {
+    const feedbacks = reviews
+      .filter(review => review.revieweeId === currentUser.id)
+      .map(({ reviewerId, revieweeId, ...review }) =>
+        expect.objectContaining({
+          ...review,
+          reviewer: users.find(user => user.id === reviewerId).email,
+        })
+      );
+
+    const { status, data } = await api.get('/feedbacks', {
+      headers: {
+        Cookie: currentUser.cookie,
+      },
+    });
+
+    expect(status).toBe(200);
+    expect(data.data).toEqual(expect.arrayContaining(feedbacks));
+  });
+});

server/api/__tests__/reviews.test.js

@@ -0,0 +1,107 @@
+const db = require('../../db/models');
+const { admin, users } = require('../../db/mockData');
+const generateReview = require('../../db/utils/generateReview');
+const { initMockData, getCookieByUser } = require('./utils');
+
+const api = global.createApi('/api/v1/reviews');
+
+const currentUser = users[0];
+
+beforeAll(async () => {
+  await initMockData();
+
+  /**
+   * Get cookies
+   */
+  admin.cookie = await getCookieByUser(admin);
+  currentUser.cookie = await getCookieByUser(currentUser);
+});
+
+describe('create a review', () => {
+  let reviewId;
+
+  beforeEach(() => {
+    reviewId = null;
+  });
+
+  afterEach(async () => {
+    if (reviewId) {
+      await db.Reviews.destroy({ where: { id: reviewId } });
+    }
+  });
+
+  it('should succeed with admin user', async () => {
+    const review = {
+      reviewerId: currentUser.id,
+      revieweeId: admin.id,
+    };
+
+    const { status, data } = await api.post('/', review, {
+      headers: {
+        Cookie: admin.cookie,
+      },
+    });
+
+    reviewId = data.data.id;
+
+    expect(status).toBe(200);
+    expect(data.data).toMatchObject(review);
+  });
+});
+
+describe('upsert a feedback for target review', () => {
+  const review = generateReview(admin, currentUser);
+  let reviewId;
+
+  beforeEach(async () => {
+    reviewId = (await db.Reviews.create(review)).get('id');
+  });
+
+  afterEach(async () => {
+    if (reviewId) {
+      await db.Reviews.destroy({ where: { id: reviewId } });
+      reviewId = null;
+    }
+  });
+
+  it('should succeed with reviewer', async () => {
+    const feedback = {
+      rating: 5,
+      content: 'fake feedback',
+    };
+
+    const { status, data } = await api.post(`/${reviewId}/feedback`, feedback, {
+      headers: {
+        Cookie: admin.cookie,
+      },
+    });
+
+    expect(status).toBe(200);
+    expect(data.data).toMatchObject(feedback);
+  });
+});
+
+describe('delete a review', () => {
+  const review = generateReview(admin, currentUser);
+  let reviewId;
+
+  beforeEach(async () => {
+    reviewId = (await db.Reviews.create(review)).get('id');
+  });
+
+  afterEach(async () => {
+    if (reviewId) {
+      await db.Reviews.destroy({ where: { id: reviewId } });
+    }
+  });
+
+  it('should succeed with admin user', async () => {
+    const { status } = await api.delete(`/${reviewId}`, {
+      headers: {
+        Cookie: admin.cookie,
+      },
+    });
+
+    expect(status).toBe(200);
+  });
+});