JENKINS-64125 removing hidden fields (jenkinsci#399)

artheus · Nov 9, 2020 · cece73d · cece73d
1 parent 9b09823
commit cece73d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 20 deletions.
diff --git a/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketSCMNavigator.java b/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketSCMNavigator.java
@@ -618,14 +618,6 @@ public FormValidation doCheckCredentialsId(@AncestorInPath SCMSourceOwner contex
             return BitbucketCredentials.checkCredentialsId(context, value, serverUrl);
         }
 
-        @SuppressWarnings("unused") // used By stapler
-        public static FormValidation doCheckServerUrl(@QueryParameter String value) {
-            if (BitbucketEndpointConfiguration.get().findEndpoint(value) == null) {
-                return FormValidation.error("Unregistered Server: " + value);
-            }
-            return FormValidation.ok();
-        }
-
         @SuppressWarnings("unused") // used By stapler
         public ListBoxModel doFillCredentialsIdItems(@AncestorInPath SCMSourceOwner context,
                                                      @QueryParameter String serverUrl) {

diff --git a/.../resources/com/cloudbees/jenkins/plugins/bitbucket/BitbucketSCMSource/config-detail.jelly b/.../resources/com/cloudbees/jenkins/plugins/bitbucket/BitbucketSCMSource/config-detail.jelly
@@ -1,17 +1,8 @@
 <?jelly escape-by-default='true'?>
 <j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:c="/lib/credentials" xmlns:scm="/jenkins/scm/api/form">
-  <j:choose>
-    <j:when test="${descriptor.serverUrlSelectable}">
-      <f:entry title="${%Server}" field="serverUrl">
-        <f:select/>
-      </f:entry>
-    </j:when>
-    <j:otherwise>
-      <f:invisibleEntry>
-        <f:select field="serverUrl"/>
-      </f:invisibleEntry>
-    </j:otherwise>
-  </j:choose>
+  <f:entry title="${%Server}" field="serverUrl">
+    <f:select/>
+  </f:entry>
   <f:entry title="${%Credentials}" field="credentialsId">
     <c:select/>
   </f:entry>