Skip to content

Commit

Permalink
Remove pytest.fixtures to avoid pytest warnings (awslabs#543)
Browse files Browse the repository at this point in the history
  • Loading branch information
fhieber authored Sep 28, 2018
1 parent 36a36e2 commit 3e554ad
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 15 deletions.
1 change: 0 additions & 1 deletion test/unit/test_inference.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
_EOS = -1


@pytest.fixture
def mock_translator(batch_size: int = 1,
beam_size: int = 5,
beam_prune: float = 0,
Expand Down
20 changes: 6 additions & 14 deletions test/unit/test_translate.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
import unittest.mock
from tempfile import TemporaryDirectory

import pytest

import sockeye.constants
import sockeye.inference
import sockeye.output_handler
Expand All @@ -27,16 +25,6 @@
"Test file line 2\n"


@pytest.fixture
def mock_translator():
return unittest.mock.Mock(spec=sockeye.inference.Translator)


@pytest.fixture
def mock_output_handler():
return unittest.mock.Mock(spec=sockeye.output_handler.OutputHandler)


def mock_open(*args, **kargs):
# work-around for [MagicMock objects not being iterable](http://bugs.python.org/issue21258)
# cf. http://stackoverflow.com/questions/24779893/customizing-unittest-mock-mock-open-for-iteration
Expand All @@ -45,7 +33,9 @@ def mock_open(*args, **kargs):
return f_open


def test_translate_by_file(mock_translator, mock_output_handler):
def test_translate_by_file():
mock_output_handler = unittest.mock.Mock(spec=sockeye.output_handler.OutputHandler)
mock_translator = unittest.mock.Mock(spec=sockeye.inference.Translator)
mock_translator.translate.return_value = ['', '']
mock_translator.num_source_factors = 1
mock_translator.batch_size = 1
Expand All @@ -63,7 +53,9 @@ def test_translate_by_file(mock_translator, mock_output_handler):


@unittest.mock.patch("sys.stdin", io.StringIO(TEST_DATA))
def test_translate_by_stdin_chunk2(mock_translator, mock_output_handler):
def test_translate_by_stdin_chunk2():
mock_output_handler = unittest.mock.Mock(spec=sockeye.output_handler.OutputHandler)
mock_translator = unittest.mock.Mock(spec=sockeye.inference.Translator)
mock_translator.translate.return_value = ['', '']
mock_translator.num_source_factors = 1
mock_translator.batch_size = 1
Expand Down

0 comments on commit 3e554ad

Please sign in to comment.