Closes #500 Python3.11 and | syntax works for model creation #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyn0
commented
Oct 11, 2024
rhyn0
commented
- add: test for failing syntax behavior
- fix: Fixes Unable to build model for Python3.11 using '|' syntax #500 | syntax results in model creation error
only runs on python3.10 or higher via pytest.skipif
tiangolo
approved these changes
Oct 18, 2025
Collaborator
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
This looks good to me, I do something similar in FastAPI. 🤓
The CI failures are not related to this change, it's something with the current CI setup. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.