Skip to content

Comments

Documentation for the sync engine#238

Merged
art049 merged 8 commits intomasterfrom
sync-engine-docs
Aug 24, 2022
Merged

Documentation for the sync engine#238
art049 merged 8 commits intomasterfrom
sync-engine-docs

Conversation

@art049
Copy link
Owner

@art049 art049 commented Aug 21, 2022

Document the feature added by #231
@tiangolo I would be glad to have your feedback on this :)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2022

🚀 Deployed on https://docs-preview-238--odmantic.netlify.app

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #238 (8e15fa5) into master (38ffda7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #238   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         3480      3480           
  Branches       590       590           
=========================================
  Hits          3480      3480           
Flag Coverage Δ
tests-3.10-4-standalone 98.50% <ø> (ø)
tests-3.10-4.2-standalone 98.50% <ø> (ø)
tests-3.10-4.4-standalone 98.50% <ø> (ø)
tests-3.7-4-standalone 98.55% <ø> (ø)
tests-3.7-4.2-standalone 98.55% <ø> (ø)
tests-3.7-4.4-standalone 98.55% <ø> (ø)
tests-3.8-4-replicaSet 98.70% <ø> (ø)
tests-3.8-4-standalone 98.50% <ø> (ø)
tests-3.8-4.2-sharded 97.32% <ø> (ø)
tests-3.8-4.2-standalone 98.50% <ø> (ø)
tests-3.8-4.4-standalone 98.50% <ø> (ø)
tests-3.9-4-standalone 98.39% <ø> (ø)
tests-3.9-4.2-standalone 98.39% <ø> (ø)
tests-3.9-4.4-standalone 98.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🚀 🎉

Thanks for doing this!

Also, super clever trick with the async_sync_snippet(), I didn't know that!

After this, I guess it would make sense to give a pass to the general docs wherever it says "this is an async ODM" to say "sync and async". 😎

@art049 art049 merged commit d07b9cd into master Aug 24, 2022
@art049 art049 deleted the sync-engine-docs branch August 24, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants