Conversation
a8889e9 to
1ef43ea
Compare
1ef43ea to
a32f538
Compare
Contributor
|
🚀 Deployed on https://docs-preview-238--odmantic.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 3480 3480
Branches 590 590
=========================================
Hits 3480 3480
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tiangolo
approved these changes
Aug 24, 2022
Collaborator
tiangolo
left a comment
There was a problem hiding this comment.
Amazing! 🚀 🎉
Thanks for doing this!
Also, super clever trick with the async_sync_snippet(), I didn't know that!
After this, I guess it would make sense to give a pass to the general docs wherever it says "this is an async ODM" to say "sync and async". 😎
0c33f36 to
8e15fa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the feature added by #231
@tiangolo I would be glad to have your feedback on this :)