-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for summaries not being loaded from directories with no refID #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ync and subtitles. Fuz files are now created instead of lip/wav, as the game does not cache fuz files. The same fuz file gets reused for every sentence, in the dedicated MantellaVoice00 directory. Extended the retries for xVAsynth connection to 20 as it was timing out.
…d 'fallout4' classes so the appropriate name is used for each game. Added some logic to output_manager sentence splitting to prevent sentences longer than 150 bytes from reaching the game.
…e a single voice directory, like Fallout.
Moved reference to 'style.css' from 'src/ui' to 'data/ui' at runtime. Added spec file, batch file for EXE generation. Added Visual Studio project files.
…for load indexes > 127.
Removed message about 'conversation not starting...'. Shouldn't happen with dedicated Mantella Voicetype.
Moved TTS temp files into environment-defined TMP directory, to prevent files from being synced by OneDrive.
Moved TTS temp files into environment-defined TMP directory, to prevent files from being synced by OneDrive.
…g a sanitized version of the voiceline text as filename. Enable language support in lip generation for EN,FR,ES,DE,IT,KO and JP.
Using new Bethesda tools for lip generation. Saved voice files now renamed using sanitized version of the voiceline text.
art-from-the-machine
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed so new directories are created using name + refID
Added a test to mask LipGen error messages if voice line is very short, like 'smile', 'winking', 'laugh', etc.