Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if summary folder exists with name and ref before checking just name #500

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Check if summary folder exists with name and ref before checking just name #500

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a8b4b
Check if summary folder exists with name and ref before checking just…
art-from-the-machine Feb 6, 2025
c206c41
Create new summary folders with name and ref
art-from-the-machine Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/remember/summaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,14 @@ def __get_latest_conversation_summary_file_path(self, character: Character, worl
# if multiple NPCs in a conversation have the same name (eg Whiterun Guard) their names are appended with number IDs
# these IDs need to be removed when saving the conversation
name: str = utils.remove_trailing_number(character.name)
name_ref: str = f'{name} - {character.ref_id}'

name_conversation_folder_path = os.path.join(self.__game.conversation_folder_path, world_id, name)
if os.path.exists(name_conversation_folder_path): # if a conversation folder already exists for this NPC, use it
name_ref_conversation_folder_path = os.path.join(self.__game.conversation_folder_path, world_id, name_ref)
if os.path.exists(name_ref_conversation_folder_path): # search by name and reference number
character_conversation_folder_path = name_ref_conversation_folder_path
else: # search by just name
name_conversation_folder_path = os.path.join(self.__game.conversation_folder_path, world_id, name)
character_conversation_folder_path = name_conversation_folder_path
else: # else include the NPC's reference ID in the folder name to differentiate generic NPCs
name_ref: str = f'{name} - {character.ref_id}'
character_conversation_folder_path = os.path.join(self.__game.conversation_folder_path, world_id, name_ref)

if os.path.exists(character_conversation_folder_path):
# get all files from the directory
Expand All @@ -84,13 +85,13 @@ def __get_latest_conversation_summary_file_path(self, character: Character, worl
latest_file_number = max(file_numbers)
logging.info(f"Loaded latest summary file: {character_conversation_folder_path}/{name}_summary_{latest_file_number}.txt")
else:
logging.info(f"{character_conversation_folder_path} does not exist. A new summary file will be created.")
logging.info(f"{name_ref_conversation_folder_path} does not exist. A new summary file will be created.")
latest_file_number = 1
else:
logging.info(f"{character_conversation_folder_path} does not exist. A new summary file will be created.")
logging.info(f"{name_ref_conversation_folder_path} does not exist. A new summary file will be created.")
latest_file_number = 1

conversation_summary_file = f"{character_conversation_folder_path}/{name}_summary_{latest_file_number}.txt"
conversation_summary_file = f"{name_ref_conversation_folder_path}/{name}_summary_{latest_file_number}.txt"
return conversation_summary_file

@utils.time_it
Expand Down