Fix for negative actorIDs #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ync and subtitles. Fuz files are now created instead of lip/wav, as the game does not cache fuz files. The same fuz file gets reused for every sentence, in the dedicated MantellaVoice00 directory. Extended the retries for xVAsynth connection to 20 as it was timing out.
…d 'fallout4' classes so the appropriate name is used for each game. Added some logic to output_manager sentence splitting to prevent sentences longer than 150 bytes from reaching the game.
…e a single voice directory, like Fallout.
Moved reference to 'style.css' from 'src/ui' to 'data/ui' at runtime. Added spec file, batch file for EXE generation. Added Visual Studio project files.
…for load indexes > 127.
Removed message about 'conversation not starting...'. Shouldn't happen with dedicated Mantella Voicetype.
art-from-the-machine
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The game sends the actor baseID and refIDs as ints. These will be sent as negative integers for load indexes > 127, including all 'lite' mods. This fixes those numbers and fixes the masking off of the load index for ESP FE/ lite mods.
The fix is in: game_manager.py and utils.py. All the other changes should already be merged.