Save conversations with generic NPCs #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made saving conversations with generic NPCs possible. For a given NPC, if a conversation folder already exists, conversations are saved to this folder as usual. However, if this folder does not exist, the saved folder name will be generated in the format "NPC Name - Reference ID".
This means that moving forward, NPC folder names will be in the "NPC Name - Reference ID" format, while existing NPC folders will remain the same to avoid players having to rename pre-existing NPC folder names. With the new format, including the Reference ID allows unique identification of generic NPCs.