Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate summary paragraphs only once #342

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/remember/summaries.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,27 @@ def get_prompt_text(self, npcs_in_conversation: Characters, world_id: str) -> st
str: a concatenation of the summaries as a single string
"""
result = ""
paragraphs: list[str] = []
for character in npcs_in_conversation.get_all_characters():
if not character.is_player_character:
conversation_summary_file = self.__get_latest_conversation_summary_file_path(character, world_id)
if os.path.exists(conversation_summary_file):
if os.path.exists(conversation_summary_file):
with open(conversation_summary_file, 'r', encoding='utf-8') as f:
previous_conversation_summaries = f.read()
# character.conversation_summary = previous_conversation_summaries
if len(npcs_in_conversation) == 1 and len(previous_conversation_summaries) > 0:
result = f"Below is a summary for each of your previous conversations:\n\n{previous_conversation_summaries}"
elif len(npcs_in_conversation) > 1 and len(previous_conversation_summaries) > 0:
result += f"{character.name}: {previous_conversation_summaries}"
return result
split = previous_conversation_summaries.split("\n")
for paragraph in split:
if paragraph != "" and not paragraphs.__contains__(paragraph):
paragraphs.append(paragraph)
# # character.conversation_summary = previous_conversation_summaries
# if len(npcs_in_conversation) == 1 and len(previous_conversation_summaries) > 0:
# result = f"Below is a summary for each of your previous conversations:\n\n{previous_conversation_summaries}"
# elif len(npcs_in_conversation) > 1 and len(previous_conversation_summaries) > 0:
# result += f"{character.name}: {previous_conversation_summaries}"
if len(paragraphs) > 0:
result = "\n".join(paragraphs)
return f"Below is a summary of past events:\n {result}"
else:
return ""

def save_conversation_state(self, messages: message_thread, npcs_in_conversation: Characters, world_id: str, is_reload=False):
summary = ''
Expand Down