Fixed summary when dismissing NPCs, several smaller TTS issues and more #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If an NPC is dismissed from a conversation, a summary is created and every NPC including the dismisses one will get it - fixed potential type error with `APIConnectionError` in `output_manager.py` - fixed typo on `skyrim.py` that caused the weather classification to crash when the weather ID was unknown.
- added class `SynthesizationOptions` in `synthesization_options.py`. - simple data holding class for additional information that can influence the synthesization of a voice line - contains the `aggro` information now that was missing after the tts rework - is passed to `ttsable.tts_synthesize` in place of the old aggro bool - fixed typo that caused the start of the xVASynth server from MantellaSoftware to fail - attempted fix of the `samplerate` error by wrapping it into a try/catch - fixed typo in float config values written to ``config.ini` - added additional cleanups to the `keyword_extraction` in `output_manager.py` to fix cases of keywords not being recognised if there are `*` or `"` right before it
Leidtier
changed the title
- Fixed weather, location and time update events not adding correctly. - Added conversion method from Skyrim decimal ID to Skyrim hexadecimal ID - Weather now uses hex ID - `skyrim_weather.csv` updated to use hex ID
art-from-the-machine
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIConnectionErrorinoutput_manager.pyskyrim.pythat caused the weather classification to crash when the weather ID was unknown.SynthesizationOptionsinsynthesization_options.py.aggroinformation now that was missing after the tts reworkttsable.tts_synthesizein place of the old aggro boolsamplerateerror xVASynth Error with samplerate #335 by wrapping it into a try/catchconfig.inikeyword_extractioninoutput_manager.pyto fix cases of keywords not being recognised if there are*or"right before itskyrim_weather.csvupdated to use hex ID