Misc fixes : NPC lookup and audio files copy #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the audio files copy for Fallout 4 in fallout4.py. The wav files are not used anymore since FO4 caches audio in a way that prevent wav file substitutions while the game is running. The wav files also cause crashes when trying to load new NPCs that are absent from the voide model list. Add an additional try block in prepare_sentence_for_game() for Fallout 4 that attempts creates a missing subdirectory for the voice file in the Mantella.esp directory if it's absent for some reason. Fix the FEMALE_VOICE_MODELS & MALE_VOICE_MODELS lookup functions so that they correctly append "Race" at the end of the search string for both Fallout4.py & Skyrim.py Fix the if condition check for actor_race in prepare_sentence_for_game() for Skyrim and Fallout to correctly compared to an integer instead of a string
art-from-the-machine
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the audio files copy for Fallout 4 in fallout4.py. The wav files are not used anymore since FO4 caches audio in a way that prevent wav file substitutions while the game is running. The wav files also cause crashes when trying to load new NPCs that are absent from the voide model list.
Add an additional try block in prepare_sentence_for_game() for Fallout 4 that attempts creates a missing subdirectory for the voice file in the Mantella.esp directory if it's absent for some reason.
Fix the FEMALE_VOICE_MODELS & MALE_VOICE_MODELS lookup functions so that they correctly append "Race" at the end of the search string for both Fallout4.py & Skyrim.py
Fix the if condition check for actor_race in prepare_sentence_for_game() for Skyrim and Fallout to correctly compared to an integer instead of a string