Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework config values and add settings GUI #268

Merged
merged 37 commits into from
Jun 8, 2024
Merged

Rework config values and add settings GUI #268

merged 37 commits into from
Jun 8, 2024

Conversation

Leidtier
Copy link
Contributor

@Leidtier Leidtier commented May 4, 2024 •
edited
Loading

based on #205 (so maybe integrate this into the base PR first or merge this PR instead)
solves #235

Rework config values

  • complete rework of how config values work in MantellaSoftware
  • All config values are now defined in code, including:
    • ID
    • Name
    • Description
    • Value
    • Default Value
    • Constraints
    • IsHidden
    • Tags
    • OnValueChangeCallback
  • On start of the software an instance that holds the current value of each config value is generated from the definitions
  • These instances are filled gracefully by which config values can be loaded from the config.ini
  • If there is no config.ini a new one will be created from scratch
  • ConfigLoader loads the config values now from the current values. Any config value that is actually loaded can trigger a constraint violation
  • Any unsolved constraint violations will block the Mantella HTTP routes for conversation or STT from being used until resolved
  • A restart of MantellaSoftware is no longer required when changing config values from the GUI

Add settings GUI

  • Adds a browser based GUI to MantellaSoftware that uses Gradio
  • Changes the Flask server to FastAPI/uvicorn to support serving the new HTTP routes for Mantella as well as the Gradio GUI from the same app
    • No explicit test done, but the responses feel faster than with Flask

Leidtier and others added 30 commits March 10, 2024 19:22
@Leidtier
first commit of feature complete http implementation
99368b5
@Leidtier
Made JSON and sentence_queue logging optional
e1639c1 
Also removed two more file communications
@Leidtier
Added different token limit between prompt length and conversation le…
7d66557 
…ngth

This should make an infinite conversation reload loop less likely
@Leidtier
Better error handling, fixes to conversation and message conversion b…
3167d9f 
…etween types

- improved the error handling
- conversations now restart every time a "start conversation" is received
- fixes to the generation of prompts now that the player is part of the characters in the conversation
- improved converting messages between multi-npc, radiant and normal conversations
- moved the conversation summary pathes from charater_manager.py to summaries.py
@Leidtier
Merge remote-tracking branch 'upstream/main' into http-integration
bc3f7b0
@Leidtier
Update tts.py
ae72196
@Leidtier
WIP integrating Fallout4 and HTTP
f20b78d
@Leidtier
Merge remote-tracking branch 'upstream/main' into http-integration
6bb4d16
@Leidtier
Merge completed. Skyrim via HTTP works again
cffbc52
@Leidtier
Added custom context values
b12336b 
- Added custom context values
- Made Fallout4 use these custom context value to receive the player pos and rot even in a radiant conversation
- removed the standard logging to console of Flask
@Leidtier
removed the files in data_new that should not have been comitted
b999e70
@Leidtier
Fixed bug when retrieving non existent custom_context_values
6bb0c11
@Leidtier
Fixed voice playback not working for Fallout4
c9914a0
@Leidtier
Removed config.ini values; removed voice files after being played by …
54b14db 
…Fallout4; cleaned Files and added docstrings
@Leidtier
Merge remote-tracking branch 'upstream/main' into http-integration
2a39130
@Leidtier
Completed Merge and improved error handling
b018df1
@Leidtier
Added file communication compatibility mode
8155af3 
- Added a compatibility mode that can be used if games can only communicate over file read/write
- fixed config values show_http_debug_message not being used
- improved readability of HTTP debug messages
@Leidtier
Removed the old config.ini_mine_old
863234f
@Leidtier
Added lower casing for JSON keys and route in file_communication_comp…
4ce80cc 
…atibility

Fixed show_http_debug_messages config value
Removed .vscode/launch.json
@Leidtier
Added config value definitions and changed handling of config values …
ff941ca 
…to the new system
@Leidtier
Changed setup of ConfigValues to be editable while Mantella is running
0735e5b
@Leidtier
First draft of a GUI for config values
9d168d3
@Leidtier
Added path picker; Fixed config value update not working correctly
37e8478
@Leidtier
Added multi tab design and improved styling
941c505 
Favicon not working for some reason
@Leidtier
Added graceful loading of old config.ini; added advanced config value…
5c85629 
…s; added tags in backend; reorganized existing config values
@Leidtier
Added a style.css for the GUI; Fixed input field for multiline string…
fb7a080 
…s; Changed the styling on some elements
@Leidtier
Added support for removing NPCs
490fbe4
@Leidtier
Fixed second route not initialized if first route has been initialize…
8db59f9 
…d before; Fixed config.ini backup not working correctly
@Leidtier
Fixed version incompatibility between 'requests' and 'gradio/fastapi'
99c33c4
@art-from-the-machine
Fixed config value changes
022bb4e
@art-from-the-machine art-from-the-machine merged commit dd52e05 into art-from-the-machine:main Jun 8, 2024
@Leidtier Leidtier deleted the gui branch September 6, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-from-the-machine art-from-the-machine art-from-the-machine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leidtier @art-from-the-machine