Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fonts (Rec Mono series) have name/behavior conflicts on Windows #336

Closed
jdknezek opened this issue Apr 5, 2020 · 7 comments
Closed

Comments

@jdknezek
Copy link

jdknezek commented Apr 5, 2020

Problem description
There are several possibly-related issues with the Rec Mono (Code) series on Windows:

  • Fonts have strange names like "Rec Mono Linear Mono Linear", "Rec Mono Duotone Mono Linear" / "Rec Mono Duotone Mono Casual"
  • Possibly due to these strange names and overlaps, italics often don't work correctly
    • Rec Mono Casual sometimes has no italic styles
    • Rec Mono Linear & SemiCasual sometimes has no non-italic styles
    • Rec Mono Duotone sometimes doesn't correctly switch between linear/casual based on italic (e.g. VS Code)

Expected behavior
I would expect to specify "Rec Mono Linear" or "Rec Mono Casual" for regular styles, with italics & weights being properly applied. I would expect "Rec Mono Duotone" to use casual styles when displayed in an italic style.

Screenshots
Rec Mono Linear properties (duplicate names, no regular style):
image

Rec Mono Casual properties (duplicate names, no italic style):
image

Rec Mono SemiCasual properties (no regular style):
image

Rec Mono Duotone properties:
image

VS Code not recognizing e.g. "Rec Mono Duotone":
image

VS Code recognizing "Rec Mono Duotone Mono Linear" but not applying casual italic styles:
image

To Reproduce

  1. Install Recursive Mono Code Beta 1.047 fonts
  2. Configure VS Code's font family to "Rec Mono Duotone" to no effect
  3. Configure VS Code's font family to "Rec Mono Duotone Mono Linear" for regular styles to work, but italic to not be casual

Environment (please complete the following information):

  • OS: Windows 10 build 18362
  • Editor: VS Code 1.43.2
  • Fonts: Beta 1.047

Additional context
I believe this behavior has been broken since the Rec Mono (Code) styles were released independently.

@arrowtype
Copy link
Owner

Hey @jdknezek, thank you so much for this detailed issue report! Ouch; these are some rough issues, but probably solvable without too much trouble.

Do you happen to know whether this did work as expected with release 1.043?

@arrowtype arrowtype self-assigned this Apr 19, 2020
@jdknezek
Copy link
Author

Here are the Rec Mono Duotone properties for 1.043 Beta:
image

In VS Code it requires the wonky name and strangely enough doesn't apply italic styles at all:
image
image

@arrowtype
Copy link
Owner

Okay, thanks so much for this additional detail! I will try to resolve these issues ASAP.

@jdknezek
Copy link
Author

Thanks for all your work on this font! I'm happy to provide any additional detail or testing.

@arrowtype
Copy link
Owner

I think I might have found the issue. 🤞

I replicated the problem on Windows 10 using a vmware virtual machine.

Then, I dropped the STAT tables in fonts and tried again. It seems to work for me!

@jdknezek if you want to, could you please try downloading & testing the fonts here?https://github.com/arrowtype/recursive/tree/c122f675fdf59fb3f52a624776d7997ece65e451/fonts/Recursive-Beta_1.047/Recursive_Code/Duotone-windows_fix

Here’s what I see with these:

image

image

Technical details: The STAT table is a new table meant to help apps understand the relationship in font families. This is important in the variable font, but these code families are just reg-ital-bold-boldital ("RIBBI") families, and the current instantiation script doesn't alter the STAT table, so it was accidentally labeling these styles as if they were still instances in the full variable family. Without the STAT table, it should work purely with names 1 & 2 on the name table, as RIBBI fonts traditionally have.

@jdknezek
Copy link
Author

jdknezek commented May 5, 2020

Brilliant! It looks great to me!

image

image

@arrowtype
Copy link
Owner

Amazing; thanks so much for your help in isolating this issue and testing the fix!

Other code fonts have been built and are currently available here:

https://github.com/arrowtype/recursive/tree/983fe478c806e4b100a33d08b56458c6c070be08/fonts/rec_mono-for-code

They’ll be added to a proper release soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants