Add week timeframe to Korean locale #804
Conversation
It fixes arrow-py#808 that weeks timeframe can not be formatted in korean. And it also adds special plurlized words in korean.
There was a problem hiding this comment.
Hi @comfuture and @ChangJoo-Park, thank you for the contribution, it's always nice to have extra translations by native speakers.
We need test coverage for the changes you've made, once this is done I see no impediment to merging.
There was a problem hiding this comment.
@comfuture Thank you for the locale fixes and submitting this MR!
I've added some comments, mainly for more test coverage, as we have been trying to improve the test coverage of all the locales. Other than that, looks excellent!
Cheers!
- add special forms for day/year frame in korean - add tests to pass code coverage
Codecov Report
@@ Coverage Diff @@
## master #804 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1740 1757 +17
Branches 295 300 +5
=========================================
+ Hits 1740 1757 +17
Continue to review full report at Codecov.
|
|
@krisfremen Thank you for your kind review of my clumsy contributions. I just improved the code by realizing where I was misunderstanding the behavior of locale handling internal methods. In addition, I added special Korean date/year frame expression. Although there is a feeling of excessiveness compared to other locales, the expressions commonly used in Windows and OS X. |
There was a problem hiding this comment.
@comfuture great work, just a few more things before it's all good to go.
|
I'll leave it for @krisfremen to approve but I'm happy with the PR. |
It fixes #808 that weeks timeframe can not be formatted in korean.
And it also adds special plurlized words in korean.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Related: #803
Closes: #803