Skip to content

Conversation

@lahwaacz
Copy link
Contributor

@lahwaacz lahwaacz commented Jun 22, 2024

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Removed typing_extensions imports which were used for python<3.8, but this package requires python>=3.8.

typing_extensions was used for python<3.8, but this package requires
python>=3.8
@lahwaacz lahwaacz force-pushed the typing_extensions branch from 8d51572 to f60be3b Compare June 22, 2024 07:17
@krisfremen krisfremen self-requested a review June 23, 2024 04:01
Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadchaar jadchaar merged commit 41717e5 into arrow-py:master Jun 23, 2024
@lahwaacz lahwaacz deleted the typing_extensions branch June 23, 2024 17:20
Copy link

@blindmanchina blindmanchina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants