Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pypy CI issues and begin testing against Python 3.10 #1045

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

jadchaar
Copy link
Member

@jadchaar jadchaar commented Oct 3, 2021

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Pypy3 builds recently began failing on our macOS CI runners. Turns out that this is because macOS 11 runners beginning to be used and they lack support for pypy3.6. I needed to update our workflow YAML to manually invoke pypy3.7 to fix this issue.

While I was at it, I also added support for testing against python 3.10 since it is in the final RC stages and will be released very soon.

@jadchaar jadchaar marked this pull request as draft October 3, 2021 01:10
@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #1045 (7dce65a) into master (2f54cb8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1045   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2208      2208           
  Branches       348       348           
=========================================
  Hits          2208      2208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f54cb8...7dce65a. Read the comment docs.

@jadchaar jadchaar marked this pull request as ready for review October 3, 2021 01:16
@jadchaar jadchaar changed the title Fix pypy CI issues and add Python 3.10 Fix pypy CI issues and begin testing against Python 3.10 Oct 3, 2021
@jadchaar jadchaar merged commit 8b4e566 into master Oct 3, 2021
@jadchaar jadchaar deleted the fix-pypy-ci branch October 3, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants