-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an "all" granularity to humanize #1018
Open
MarkKoz
wants to merge
9
commits into
arrow-py:master
Choose a base branch
from
MarkKoz:1014/all-granularity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+53
−2
Commits on Aug 8, 2021
-
Add an "all" granularity to humanize
It's more convenient to pass a simple short string than to pass a list of 7 strings. Resolve arrow-py#1014
Configuration menu - View commit details
-
Copy full SHA for 89f77b1 - Browse repository at this point
Copy the full SHA 89f77b1View commit details
Commits on Oct 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 450bd09 - Browse repository at this point
Copy the full SHA 450bd09View commit details
Commits on Oct 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cc8c4dd - Browse repository at this point
Copy the full SHA cc8c4ddView commit details
Commits on Dec 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e218120 - Browse repository at this point
Copy the full SHA e218120View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06dd630 - Browse repository at this point
Copy the full SHA 06dd630View commit details -
Fix inconsistent 'all' granularity test results
The assertions only worked for certain dates and times. For example, a difference of 2 months could result in "1 month and 29 days" rather than "2 months" depending on the start time. Since utcnow() was used, assertions could fail if ran at a later date. Fix this by using a fixed time for test data rather than utcnow().
Configuration menu - View commit details
-
Copy full SHA for b2d2894 - Browse repository at this point
Copy the full SHA b2d2894View commit details -
Fix relative affix for 'all' granularity test data
Since arrow-py#996 was fixed by arrow-py#1077, the test no longer needs to use the incorrect data to work around the bug.
Configuration menu - View commit details
-
Copy full SHA for ea3c1ae - Browse repository at this point
Copy the full SHA ea3c1aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 804eece - Browse repository at this point
Copy the full SHA 804eeceView commit details
Commits on Oct 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 71d5233 - Browse repository at this point
Copy the full SHA 71d5233View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.