Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Kotlin community build #3140

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Prepare for Kotlin community build #3140

merged 3 commits into from
Oct 11, 2023

Conversation

serras
Copy link
Member

@serras serras commented Oct 11, 2023

We've been asked to become part of a large set of repositories which are tested with new versions of Kotlin. To become part of the program, we need to handle a few Gradle variables that set the Kotlin compiler and language version.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Kover Report

File Coverage [50.00%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt 50.00%
Total Project Coverage 50.05%

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @serras!

Do you think it's worth planning the rewrite from Kotest to Kotlin-test? For example for experimental targets like wasm? I've thought we might be able to automate this using OpenRewrite, but the biggest problem I see is our reliance on Arb. We'd need to write our own :/

Unless Kotest manages to only use "stable" compiler APIs, it's constantly going to be breaking on new versions.

@serras
Copy link
Member Author

serras commented Oct 11, 2023

Do you think it's worth planning the rewrite from Kotest to Kotlin-test? For example for experimental targets like wasm? I've thought we might be able to automate this using OpenRewrite, but the biggest problem I see is our reliance on Arb. We'd need to write our own :/

I'm not really sure about what's the right path here. In any case, just building the project and running JVM tests should already help the Kotlin team, so maybe we can think about next steps later?

@nomisRev
Copy link
Member

running JVM tests

That's not going to work either if the Kotest compiler plugin breaks against new version of Kotlin, right? 🤔 That is what I encountered in 1.9.20-Beta, and we pretty much had with every minor version since it came out :/

@serras serras merged commit 68938d3 into main Oct 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants