This repository was archived by the owner on Apr 22, 2025. It is now read-only.
generify tristate module as reusable module #108
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
GenericTriStateModule<T>
as a base of tristate (undefined | null | value) serde.fixes #107
Context
There are times where users need to model an API that need differentiate between:
Option is a very specific case of the above where both absence and presence of a field with a null value indicates a
None
.However it's important to note that these generalizations sometimes do not apply. For instance for PATCH endpoints where null means remove, and undefined means do nothing. In this PR we're extracting out this functionality as a separate module that users will be able to customize to support their requirements accordingly.
An example usage of the
GenericTriStateModule<T>
to form an option module is as follows:Out of scope