Fix bug: when a CRLF is in @widget, blade will complains! It is not s… #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a raw output when there is a CRLF in @widget(...). For example:
output is still:
When I dived into laravel-widgets' sources, I was surprised about the matcher in
\Arrilot\Widgets\ServiceProvider::createMatcher. Why are you recreate a matcher?After I had used
Blade::directiveinstead of$this->registerBladeDirective, it worked. The blade compile result is correct:So, hope you can accept this PR.
Sorry for my poor English.