Add more lib dir search options for build script #119
Conversation
build.rs
Outdated
| Err(_) => panic!("Error use_lib is defined, but AF_PATH is not defined"), | ||
| Err(_) => { | ||
| println!("WARNING! USE_LIB IS DEFINED, BUT AF_PATH IS NOT DEFINED, TRYING TO FIND LIBRARIES FROM KNOWN DEFAULT LOCATIONS"); | ||
| PathBuf::from("/usr/") |
There was a problem hiding this comment.
I don't understand what is happening here.
There was a problem hiding this comment.
If there is no AF_PATH, it will look for libraries in some predefined paths for platforms. If there is AF_PATH, it will also be included into the search paths.
There was a problem hiding this comment.
Makes sense, but shouldn't we look into /usr/local by default? Isn't that the default AF_PATH?
build.rs
Outdated
| Err(_) => { | ||
| println!("WARNING! USE_LIB IS DEFINED, BUT AF_PATH IS NOT DEFINED, TRYING TO FIND LIBRARIES FROM KNOWN DEFAULT LOCATIONS"); | ||
| PathBuf::from("/usr/") | ||
| }, | ||
| }; | ||
| let libpath = afpath.join("lib"); |
There was a problem hiding this comment.
Will this not be an error if AF_PATH is empty ?
There was a problem hiding this comment.
No, there won't be error. I think we can panic or use some default paths. We are not checking for existence of the libraries, we are only adding paths like -L we use for gcc/g++ link options. If required library is not present in any of search paths, it will throw linking errors.
There was a problem hiding this comment.
afpath will never be None. Under the Err it is being set to another path location. I.e. error is handled when AF_PATH is not set.
build.rs
Outdated
| Err(_) => panic!("Error use_lib is defined, but AF_PATH is not defined"), | ||
| Err(_) => { | ||
| println!("WARNING! USE_LIB IS DEFINED, BUT AF_PATH IS NOT DEFINED, TRYING TO FIND LIBRARIES FROM KNOWN DEFAULT LOCATIONS"); | ||
| PathBuf::from("/usr/") |
There was a problem hiding this comment.
Makes sense, but shouldn't we look into /usr/local by default? Isn't that the default AF_PATH?
build.rs
Outdated
| Err(_) => { | ||
| println!("WARNING! USE_LIB IS DEFINED, BUT AF_PATH IS NOT DEFINED, TRYING TO FIND LIBRARIES FROM KNOWN DEFAULT LOCATIONS"); | ||
| PathBuf::from("/usr/") | ||
| }, | ||
| }; | ||
| let libpath = afpath.join("lib"); |
There was a problem hiding this comment.
afpath will never be None. Under the Err it is being set to another path location. I.e. error is handled when AF_PATH is not set.
9prady9
force-pushed
the
build_lib_search_options
branch
from
99f8d03 to
c9cdc36
Compare
|
@pavanky @jramapuram I have made some changes based on the feedback. Please review the latest once again. Thanks. |
9prady9
force-pushed
the
build_lib_search_options
branch
from
c9cdc36 to
02cd6dd
Compare
9prady9
changed the title
9prady9
force-pushed
the
build_lib_search_options
branch
from
02cd6dd to
f0b2ae2
Compare
9prady9
changed the title
|
@9prady9 : looks good to me! |
Fixes #118