Fallback Enum class and boolean index fix#35
Closed
pavanky wants to merge 0 commit intoarrayfire:masterfrom
Closed
Fallback Enum class and boolean index fix#35pavanky wants to merge 0 commit intoarrayfire:masterfrom
pavanky wants to merge 0 commit intoarrayfire:masterfrom
Conversation
Member
pavanky
commented
Sep 8, 2015
- Fixes Cannot index with booleans #34
Contributor
|
The name |
Member
Author
|
@FilipeMaia |
Contributor
|
Instead of having an Enum_value causing changes all over the code what about changing the way the enums are defined, e.g.: try:
from enum import Enum
def EnumType(v):
return v
except:
class Enum(object):
pass
class EnumType(object):
def __init__(self, v):
self.value = v
class Dtype(Enum):
"""
Error values. For internal use only.
"""
f32 = EnumType(0)
...That way all the changes would be in the same place. |
Member
Author
|
@FilipeMaia That would work. |
Member
Author
|
Fixed the Enum class, looking into the Index class issue. |
Member
Author
|
Welp, its broken. Fixing hit. |
Member
Author
|
Accidentally pushed to upstream :( I will fix the index issue in upstream shortly. |
Contributor
|
Ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.