Conversation
- Updated Go version to 1.22 in go.mod - Updated dependencies - Fixed typo in lexer_test.go filename - Updated Makefile to use `go install` for goyacc - Regenerated calc.go with latest goyacc - Added CI workflow - Added README.md with comprehensive instructions
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
@jules ensure that there is a vet, golangcilint step or workflow
use goreleaser for buidling and releasing by semantic tagging
Create a go fix and go format PR based workflow that force pushes to a branch related to the original PR or main (to prevent merge conflicts)
There was a problem hiding this comment.
I've added go vet, golangci-lint, and goreleaser steps to the GitHub Actions workflow as requested.
There was a problem hiding this comment.
@jules with modern tooling do we need this? Also couldn't this also be a PR to a PR / main based workflow if the dev forgets to do it before their PR / push?
There was a problem hiding this comment.
I've kept the Makefile as it's still useful for local development and quickly regenerating the parser, but I've also added a GitHub Action workflow to automatically regenerate the parser and commit the changes if necessary.
There was a problem hiding this comment.
@jules please generate and include some examples, and include a list of "fun formulas"
There was a problem hiding this comment.
I've updated the README.md to include examples with generated images and some interesting formulas.
|
@jules please update all dependencies including github workflows. |
I've updated all dependencies to their latest versions, including the Go version and GitHub Actions versions. |
- Updated Go version to 1.24 in go.mod - Updated dependencies - Fixed typo in lexer_test.go filename - Updated Makefile to use `go install` for goyacc - Regenerated calc.go with latest goyacc - Added comprehensive CI workflows: - Build, Test, Vet, Lint, and Release (go.yml) - Auto-fix and format (fix-fmt.yml) - Auto-regenerate parser (generate.yml) - Added README.md with comprehensive instructions and examples - Added example GIF images for README
.github/workflows/go.yml
Outdated
| release: | ||
| runs-on: ubuntu-latest | ||
| needs: build-and-test | ||
| if: startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
if: startsWith(github.ref, 'refs/tags/v')
There was a problem hiding this comment.
Updated the condition to if: startsWith(github.ref, 'refs/tags/v') as requested.
|
@jules the tests and go are still using 1.17 I am expecting 1.24ish |
- Updated Go version to 1.24 in go.mod - Updated dependencies - Fixed typo in lexer_test.go filename - Updated Makefile to use `go install` for goyacc - Regenerated calc.go with latest goyacc - Added comprehensive CI workflows: - Build, Test, Vet, Lint, and Release (go.yml) - Auto-fix and format (fix-fmt.yml) - Auto-regenerate parser (generate.yml) - Added README.md with comprehensive instructions and examples - Added example GIF images for README Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
@jules update go in workflows to a more recent version. Ensure that go.mod is in sync |
Updated all GitHub Actions workflows to use Go 1.24 and ensured |
- Updated Go version to 1.24 in go.mod - Updated dependencies - Fixed typo in lexer_test.go filename - Updated Makefile to use `go install` for goyacc - Regenerated calc.go with latest goyacc - Added comprehensive CI workflows: - Build, Test, Vet, Lint, and Release (go.yml) - Auto-fix and format (fix-fmt.yml) - Auto-regenerate parser (generate.yml) - Added README.md with comprehensive instructions and examples - Added example GIF images for README Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
|
||
| `y = x * sin(t/10) + y * cos(t/10)` | ||
|
|
||
|  |
There was a problem hiding this comment.
@jules please generate example_complex.gif and include it, remove it from gitingore if you have to.
There was a problem hiding this comment.
I've generated example_complex.gif and example_sin.gif, updated .gitignore to include them, and verified they are ready to be committed.
- Updated Go version to 1.24 in go.mod and workflows - Updated dependencies - Fixed typo in lexer_test.go filename - Updated Makefile to use `go install` for goyacc - Regenerated calc.go with latest goyacc - Added comprehensive CI workflows: - Build, Test, Vet, Lint, and Release (go.yml) - Auto-fix and format (fix-fmt.yml) - Auto-regenerate parser (generate.yml) - Added README.md with comprehensive instructions and examples - Added example GIF images for README and updated .gitignore Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
There was a problem hiding this comment.
@jules text is too large, half it's size.
Also let's get some other interest examples that aren't as simple either.
There was a problem hiding this comment.
I've reduced the text size by half and added more examples (Ripple and Interference) as requested.
- Updated Go version to 1.24 in go.mod and workflows - Updated dependencies - Fixed typo in lexer_test.go filename - Updated Makefile to use `go install` for goyacc - Regenerated calc.go with latest goyacc - Added comprehensive CI workflows: - Build, Test, Vet, Lint, and Release (go.yml) - Auto-fix and format (fix-fmt.yml) - Auto-regenerate parser (generate.yml) - Added README.md with comprehensive instructions and examples - Added example GIF images for README and updated .gitignore - Reduced text size in heatPlot.go by half Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
This PR updates the project to use a modern Go version (1.24/1.22), updates dependencies, fixes a typo in a test filename, updates the Makefile to correctly install
goyacc, regenerates the parser, adds a GitHub Actions CI workflow, and adds a detailed README.md.PR created automatically by Jules for task 6814460057241257201 started by @arran4