[issue-1287] added io.undertow Http2* replacement classes for io.unde… #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtow.Spdy* classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rtow.Spdy* classes
-- REVIEW ACTION REQUESTED --
The files in this PR are intended to replace the io.undertow.Spdy* classes
with io.undertow.Http2* classes. io.undertow.Spdy* class were removed
and replaced with io.undertow.Http2* classes. Arquillian-cube implemented class
SpdyChannelWithoutFlowControl. New class Http2ChannelWithoutFlowControl
has been created to replace it. Is the code appropriate for the task?
Please pay particular attention to PortForward line 261. Is using
this.portForwardURI.getHost() the proper reference to use as "defaultHost"
in Http2ClientConnection?
Http2ChannelWithoutFlowControl line 19. There are 3 possible
constructors to Http2Channel. Is this the proper one to use and are the input
parameters appropriate?
Http2ChannelWithoutFlowControl line 33. Is this an appropriate way to
handle this IOException?