[580] Create some integration tests. Create profiles for WildFly to r… #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See https://github.com/flowlogix/base-pom the way I did this for Payara so that profiles are not repeated for every project. |
|
@jamezp What about not having this inherrit the arquillian-parent pom and only use the bom? The reason is that it can be used to test any version of arquillian-core. For example, I have a local 1.9.0.Final-SNAPSHOT build and I want to run these test against it, but I have to go through all of the poms and update the version. If it was just importing the bom and using a property, it could be retargeted using a command line override. |
|
I guess I can already override the version on the command line. |
|
Yeah, you should be able to override it. It definitely doesn't need to have the parent POM for sure. I'll make sure to set it up to allow all dependencies to be overridden so we can test in CI too. |
jamezp
commented
Jul 8, 2024
Comment on lines
+10
to
+12
| pull_request: | ||
| branches: | ||
| - '**' |
There was a problem hiding this comment.
This will add 12 jobs to each PR. I'm not sure if we want to do that, but welcome feedback.
There was a problem hiding this comment.
What if we just run SE 21 on the integration tests on each platform automatically and have a complete integration-test job that can be run manually that covers the latest LTS and the two previous? The full set is running in 6.5 minutes which is not too bad.
jamezp
force-pushed
the
issue580
branch
2 times, most recently
from
b2a8c87
to
c656ab8
Compare
|
These Windows failures are strange. The BOM is supposed to build as the last module before the integration tests. However, it looks like it's being build second: The reactor itself looks correct though: It also didn't fail for me locally in a Windows VM. |
…Payara for testing. Signed-off-by: James R. Perkins <jperkins@redhat.com>
Signed-off-by: James R. Perkins <jperkins@redhat.com>
starksm64
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…un the tests.
Short description of what this resolves:
Introduce some integration tests.
Changes proposed in this pull request:
Fixes #580