Add onSubtractTime and onAddTime hooks

[DaanDD]

Description

Implement hooks for onSubtractTime and onAddTime.

Motivation and Context

This could be used to dynamically load selectable dates for each month.

Checklist

[ ] I have added tests covering my changes
[x] All new and existing tests pass
[x] My changes required the documentation to be updated
  [x] I have updated the documentation accordingly
  [x] I have updated the TypeScript 1.8 type definitions accordingly
  [x] I have updated the TypeScript 2.0+ type definitions accordingly

I have ran build but it seems to have updated more than only my changes in the dist folder.

[simeg]

Hi @DaanDD and thanks for contributing! Your code is changing a critical part of the component but you didn't write any tests. I would like to see some tests that verifies that it's working as you want it to work.

Also, no need to update the dist files. We do that when we release a new version, please remove them from your PR. Thanks!

[DaanDD]

Hello, thanks for the feedback! I have removed the dist files and added some tests.

[simeg]

These name has time in them, but they are triggered for "months, year or group of years". It might be confusing for the user since the component has a time mode.

Naming is hard for these triggers, onSubtractMonthsOrYears is more correct but it's long.

What are your thoughts?

[DaanDD]

onSubtractMonthsOrYears seems a bit long, maybe something like onNavigateBack and onNavigateForward?

[simeg]

I like that better, because navigating time doesn't really make sense. Let's go with that, what do you say?

[simeg]

You are testing onAddTime here and onSubtractTime in the next describe(), a mixup :)

[DaanDD]

@simeg I have changed the hook names. onSubtractTime and onAddTime are now called onNavigateBack and onNavigateForward

[simeg]

Looks good 👍 Thanks for contributing!

[laddhadhiraj]

I am trying to call "onNavigateBack" and "onNavigateForward" both are not working. "onViewModeChange" is working well.

<Datetime input={false} timeFormat={false} onChange={this.updateDate.bind(this)} renderDay={ this.renderDay } onViewModeChange={this.dateViewMode.bind(this)} onNavigateBack={this.dateNavigate.bind(this)} onNavigateForward={this.dateNavigate.bind(this)}/>

[laddhadhiraj]

It worked for me If I install this package like npm install --save YouCanBookMe/react-datetime