Fix displayName <Unknown /> in react dev tools #335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inspecting the component in React Dev Tools, it is displayed as <Unknown /> Component, which is kind of annoying. So this PR fixes this issue.
|
Hi @dragfire and sorry for the delay. Your single commit has the changes from building this project, that is not necessary and I would like for you to remove it. Can you confirm that this is still a problem? If so we could make this mergable and merge it. |
|
Thanks for this @dragfire. I'll push this change in a separate PR, due to the inability to merge this PR. |
simeg
added a commit
that referenced
this pull request
Feb 11, 2018
simeg
added a commit
that referenced
this pull request
Feb 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting the component in React Dev Tools, it is displayed as
<Unknown />Component, which is kind of annoying.So this PR fixes this issue.
Description
displayName is added
Motivation and Context
Displaying
<Unknown />instead of<DateTime />doesn't look good.Checklist