Skip to content

Update react-onclickoutside dependency and create the CalendarContainer #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2017
Merged

Update react-onclickoutside dependency and create the CalendarContainer #276

merged 2 commits into from
Feb 27, 2017

Conversation

arqex
Copy link
Owner

@arqex arqex commented Feb 27, 2017

Description

Bring up to date the react-onclickoutside dependency. Since the newer versions of react-onclickoutside the library is shipped as a higher order component, the old code in react-datetime for adapting the clicking outside to different versions of react is not valid anymore. In its place, there is a new component wrapped by the react-onclickoutside HOC called CalendarContainer.

Now CalendarContainer component is the one that renders calendar the views, but the view to render is still defined by DateTime.

Motivation and Context

Old version of react-onclickoutside was creating conflict for projects using the branch 5.x of the same library.

Checklist

  • I have added tests covering my changes
  • All new and existing tests pass
  • My changes required the documentation to be updated
    [ ] I have updated the documentation accordingly
    [ ] I have updated the TypeScript 1.8 type definitions accordingly
    [ ] I have updated the TypeScript 2.0+ type definitions accordingly

@arqex arqex merged commit 8b74e5a into arqex:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant