Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to facilitate compilation in a Linux box #39

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

fexadom
Copy link
Contributor

@fexadom fexadom commented Mar 14, 2024

I am currently testing this code in an Arduino Nano 33 BLE (it has a Nordic nRF52480 MCU) and so far is working fine. Thank you very much for your work, it has been a life saver.

I am working on a Linux machine so I had a compilation problem with the "arduino.h" header file, the compiler could not find it. The easy fix is to change "arduino.h" to "Arduino.h" in every relevant file as the header name is actually "Arduino.h" and in case-sensitive Linux filesystems this matters. I saw in some of the closed issues that some users of this code encountered this problem so to help with a small contribution I propose this pull request that fixes this issue. This shouldn't have any negative effect on Windows systems.

…nux filesystems where filenames are case sensitive. This change does not affect compilation in a Windows environment.
@sergiocntr
Copy link

sergiocntr commented Mar 14, 2024 via email

Copy link
Owner

@aromring aromring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Indeed, case does not matter on other platforms I tested it on.

@aromring aromring merged commit 7e85424 into aromring:master Mar 14, 2024
@fexadom fexadom deleted the compile-linux branch March 14, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants