Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "perf: Only use Red & IR arrays from function param" #38

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

aromring
Copy link
Owner

@aromring aromring commented Sep 9, 2022

Reverts #37
I have accepted the changes too soon. My bad. In fact, other functions in other parts of the code still use uint32_t incompatible with float. For example, maxim_max30102_read_fifo() in max30102.cpp or the original MAXIM algorithm in algorithm.cpp.

@aromring aromring merged commit d553cad into master Sep 9, 2022
@0xMihir
Copy link
Contributor

0xMihir commented Sep 9, 2022

I used the Sparkfun library that could read into a float buffer. I'll try testing this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants