Fixes for positioning instruction view according to text height #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ezefire for your PR and time for this project. |
|
Hi Quang,
You are welcome. I do it with pleasure. Your lib is the unique lib of
showcase for material design and it is very good and simple to use.
I do the fixes when i found them in my usages.
Kind regards,
Cristian
El sáb., 18 abr. 2020 4:24, Quang Nguyen <notifications@github.com>
escribió:
… Merged #126 <#126>
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#126 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDHRYSGAYFY376YVEDSRODRNEFMZANCNFSM4MKZC65A>
.
|
|
Thank you @ezefire for your kind words and your time. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes made to positioning instruction view using its height when instruction view is below the target.
Fixes made to positioning instruction view correctly in iPad when backgroundView is outer of the right side of the screen.