swapped to v5.0.0 font file #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nick catch! According to ionicons v5 changelog, many icons have changed their names. As a result, the generated file Can you give a try, with a script ? |
|
NPM has a svg2ttf. |
|
Okay I've modified your generate.js file and have subsequently pushed a new map.json file. |
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the file over -- It looks like all the fonts worked.
I used https://github.com/FontCustom/fontcustom to convert the svg files ( https://github.com/ionic-team/ionicons/tree/master/src/svg ) to a .tff file.