Flymake PHPCS/DrupalCS Integration Not Working

[eethann]

Hi there, I was pointed to your drupal-mode by @illusori in this thread.

After a bit of wrestling, I've got PHPCS correctly linting .php files that are not in Drupal mode, but error checking is not working for .module and .php files in Drupal mode (in Drupal project dirs).

I've done a bit of debugging and determined that (a) the flymake_phpcs function is running, and (b) it's returning output. When I run the same command it runs on a given file I get a lot of errors.

Got any ideas why it might be getting so far as to be executing the phpcs command correctly, returning results, but not seeing anything in my editing window?

Thanks for sharing this great tool, it's definitely the most well architected of the options I've seen out there so far, and I'm excited to use it. Btw I also have set up a repo with a bunch of D7 snippets for drupal-mode, if you'd like to incorporate them or link, feel free.

[arnested]

I can think of a couple of things that could be wrong.

1. Do you use sym links in your Drupal project dirs?

If flymake.el and phpcs disagree about the actual filename errors will not be displayed/catched. One way they can diagree is if the file in Emacs is going through sym links.

I posted a patch to Emacs (http://article.gmane.org/gmane.emacs.devel/151775) some time ago although it haven't been applied.

Another option is to use @illusori's version of flymake.el (https://github.com/illusori/emacs-flymake). The patch has been applied to his version of flymake.el.

2. How is your Drupal Coding Standard installed?

Is it installed in PHP CodeSniffers standard location (it should be listed if you run phpcs -i) or do you set the emacs variable `drupal/flymake-phpcs-standard' to point to the path of the standard?

If you point it to the path of the standard your PHP CodeSniffer must be at least version 1.3.4. I just added that information to the documentation of the variable (8951d9a).

Otherwise I need a bit more info on which versions you are running of Emacs, phpcs, etc.

Btw. did you install my drupal-mode from marmalade-repo.org or from Github. The develop branch at github has had quite some improvements since my last release to marmalade-repo.org.

I actually had a very brief look at your D7 yasnippets some days ago. I might very well include support for them. I have been looking around for yasnippets for Drupal that are actually supported and yours seem to be the right way to go.

[eethann]

Thanks, @arnested!

It does look like the symlink issue is to blame here. I do symlink all my local webroots, and when I move the file into a non symlinked location it shoes correct syntax issues.

That said I've tried installing @illusori's patched fork (via el-get and git, which is also how I have this plugin installed), but it doesn't seem to address the issue. I'll see if it could have something to do with emacs temp file location settings or something else...

For the time being I can just open the file directly, not through the symlinked dir.

[dhaley]

My drupal installs have lots of symlinks using the drush dslm configuration.

http://drupal.org/project/dslm

I'd like to know if anyone has had success with a symlinked based drupal working with flymake under drupal-mode.

Will try some experimenting on my own and write back if I have any success.

Damon

[arnested]

@dhaley I think I've found a solution to the problem. I'll try to get the patch in good shape soon.

[arnested]

I haven't looked at this for quite some time but just had a look now and quickly discovered the bug.

Because of a change from a couple of weeks ago (b929895) it is even possible to fix the bug from drupal-mode now.

Commit being pushed in a second.