Added callback for instantVerification #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #623 Android can auto retrieve SMS send trough firebase. Some devices won't even get any SMS when they got verified instantly trough google servers. In this case, this plugin is pretty helpless as it can't do anything (there are better plugins outside like https://github.com/chemerisuk/cordova-plugin-firebase-authentication). You will need to call signInWithCustomToken() instead of creating a credential based on verificationId and code (as you wont have id nor code). This PR will give proper callbacks (instantVerification: true or false).
soumak77
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #623
Android can auto retrieve SMS send trough firebase. Some devices won't even get any SMS when they got verified instantly trough google servers. In this case, this plugin is pretty helpless as it can't do anything (there are better plugins outside like https://github.com/chemerisuk/cordova-plugin-firebase-authentication). You will need to call signInWithCustomToken() instead of creating a credential based on verificationId and code (as you wont have id nor code).
This PR will give proper callbacks (instantVerification: true or false).