Skip to content

Conversation

@mitikov
Copy link
Contributor

@mitikov mitikov commented Jul 7, 2022

Being an enrichment wrapper around double?, it makes sense to let compiler convert number to Expression where it needs.

The first commit illustrates a single prop forces us to use 2 times new ExpressionOrNumber() even though intend is crystal clear and non-twofold.

@arnaudleclerc what do you think?

Thanks.

@codecov-commenter
Copy link

Codecov Report

Merging #72 (e466ca6) into develop (e5b879f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #72   +/-   ##
========================================
  Coverage    86.45%   86.45%           
========================================
  Files          124      124           
  Lines         3655     3655           
========================================
  Hits          3160     3160           
  Misses         495      495           
Flag Coverage Δ
unittests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/AzureMapsControl.Components/Atlas/Expression.cs 96.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b879f...e466ca6. Read the comment docs.

@arnaudleclerc
Copy link
Owner

Thanks, everything looks fine. That's another great addition to the expressions :)

Would you mind also updating the documentation to explain that it is now possible to affect a double directly to an expression ? Otherwise, I am afraid this will remain mostly unknown.

You can find the documentation on docs/expressions.

@mitikov
Copy link
Contributor Author

mitikov commented Jul 8, 2022

@arnaudleclerc Sure, docs updated.

Copy link
Owner

@arnaudleclerc arnaudleclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@arnaudleclerc arnaudleclerc merged commit abeefe7 into arnaudleclerc:develop Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants