Skip to content

Conversation

@mitikov
Copy link
Contributor

@mitikov mitikov commented Jul 6, 2022

Adding primitive APIs to reduce the volume of boilerplate code to be written while working with expressions.

Inspired by #70

@mitikov
Copy link
Contributor Author

mitikov commented Jul 6, 2022

@arnaudleclerc Could you please review?

Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #71 (bccadbc) into develop (8393100) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #71   +/-   ##
========================================
  Coverage    86.45%   86.45%           
========================================
  Files          124      124           
  Lines         3655     3655           
========================================
  Hits          3160     3160           
  Misses         495      495           
Flag Coverage Δ
unittests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/AzureMapsControl.Components/Atlas/Expression.cs 96.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8393100...bccadbc. Read the comment docs.

@arnaudleclerc
Copy link
Owner

@mitikov Thanks for the PR, this is a great improvement! Everything looks fine.

Do you think it is possible to add some unit tests on the new code ?

@mitikov
Copy link
Contributor Author

mitikov commented Jul 7, 2022

@arnaudleclerc Sure, here you go :)

@arnaudleclerc arnaudleclerc merged commit e5b879f into arnaudleclerc:develop Jul 7, 2022
@arnaudleclerc
Copy link
Owner

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants