Skip to content

Make plugin work with segment.io 3.0.0 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karolk wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Make plugin work with segment.io 3.0.0 #16

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bfaac4d
do not rely on initialized flag, which is now deprecated
karolk Nov 26, 2014
db9ce5b
install grammar
karolk Nov 26, 2014
780a209
Merge pull request #1 from skimhub/fix/safely-detect-segment-io-loading
svileng Nov 26, 2014
bdb5b05
flush the queue of pending events when analytics script is loaded. Th…
Jul 22, 2015
a6ec83c
move if condition
Jul 22, 2015
bb213cd
Merge pull request #2 from skimhub/fix/onload-callback
Jul 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions angular-segmentio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,23 @@ angular.module('segmentio', ['ng'])
function($rootScope, $window, $location, $log) {
var service = {};

$window.analytics = $window.analytics || [];
// Create a temp queue for events fired before analytics loaded
// but do not attempt to create 'analytics' object.
var tempQueue = [];


function flushTempQueue () {
if (tempQueue.length) {
// Send the queue of pending events
$window.analytics.push.apply($window.analytics, tempQueue)
tempQueue.length = 0
}
}

// Analytics script is loaded callback.
var analyticsLoaded = function() {
flushTempQueue()
}

// Define a factory that generates wrapper methods to push arrays of
// arguments onto our `analytics` queue, where the first element of the arrays
Expand All @@ -12,12 +28,15 @@ angular.module('segmentio', ['ng'])
return function() {
var args = Array.prototype.slice.call(arguments, 0);
$log.debug('Call segmentio API with', type, args);
if ($window.analytics.initialized) {

//Because we didn't overwrite the analytics object we can use
//its presence as a flag that segment.io has loaded.
if ($window.analytics) {
$log.debug('Segmentio API initialized, calling API');
$window.analytics[type].apply($window.analytics, args);
} else {
$log.debug('Segmentio API not yet initialized, queueing call');
$window.analytics.push([type].concat(args));
tempQueue.push([type].concat(args));
}
};
};
Expand Down Expand Up @@ -50,6 +69,7 @@ angular.module('segmentio', ['ng'])
script.async = true;
script.src = ('https:' === document.location.protocol ? 'https://' : 'http://') +
'd2dq2ahtl5zl1z.cloudfront.net/analytics.js/v1/' + apiKey + '/analytics.js';
script.onload = analyticsLoaded

// Find the first script element on the page and insert our script next to it.
var firstScript = document.getElementsByTagName('script')[0];
Expand Down