fix: The bootstrap application should not get environment suffix #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7349386, mkApplication was created to consolidate the creation of an application but it has changed the behavior of the bootstrap application name as it started honoring config.nixidy.appendNameWithEnv and that broke the behavior of config.nixidy.bootstrapManifest.enable: ``` ❯ nixidy switch .#prod switching manifests symlink has no referent: "/nix/store/is7lk9ng28mywwr2ba405x8fcak50bxs-nixidy-environment-prod/bootstrap.yaml" ❯ ls -la /nix/store/is7lk9ng28mywwr2ba405x8fcak50bxs-nixidy-environment-prod/bootstrap.yaml lrwxr-xr-x - root 31 Dec 1969 /nix/store/is7lk9ng28mywwr2ba405x8fcak50bxs-nixidy-environment-prod/bootstrap.yaml -> /nix/store/6z6d77r4gw2dd68xn1ylrk5y9gakd9zv-nixidy-app-__bootstrap/Application-cluster-prod.yaml ❯ ls -la /nix/store/6z6d77r4gw2dd68xn1ylrk5y9gakd9zv-nixidy-app-* .r--r--r-- 540 root 31 Dec 1969 Application-cluster-prod-prod.yaml ``` As demonstrated above, the app of apps became known on disk as Application-cluster-prod-prod.yaml instead of its original/expected name Application-cluster-prod.yaml which caused the symlink to break and hence nixidy switch no longer worked when both appendNameWithEnv and bootstrapManifest.enable are set to true.
kalbasit
force-pushed
the
fix-mkapplication
branch
from
fd7f4e4 to
6336e1c
Compare
arnarg
approved these changes
Dec 22, 2025
Owner
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7349386, mkApplication was created to consolidate the creation of an application but it has changed the behavior of the bootstrap application name as it started honoring config.nixidy.appendNameWithEnv and that broke the behavior of config.nixidy.bootstrapManifest.enable:
As demonstrated above, the app of apps became known on disk as Application-cluster-prod-prod.yaml instead of its original/expected name Application-cluster-prod.yaml which caused the symlink to break and hence nixidy switch no longer worked when both appendNameWithEnv and bootstrapManifest.enable are set to true.