fix: OBB-aware volume trigger overlap for rotation and scale - #3321
Open
chenlinxi890-spec wants to merge 1 commit into
Open
fix: OBB-aware volume trigger overlap for rotation and scale#3321chenlinxi890-spec wants to merge 1 commit into
chenlinxi890-spec wants to merge 1 commit into
Conversation
- Add TransformExtension.overlap_obb() using SAT (Separating Axis Theorem) to account for rotation and scale of both objects - Replace AABB-only overlap in OnVolumeTriggerNode.hx with overlap_obb() - Replace AABB-only overlap in VolumeTriggerNode.hx with overlap_obb() - Minimal targeted change: only physics logic node overlap detection - Backward compatible: original overlap() preserved, new method additive Fixes: On Volume Trigger should take its rotation and scale into account (armory3d#2595)
Author
|
Hi maintainers, this PR currently appears to be waiting for maintainer approval before CI can run on the forked branch. Could you please approve the workflow run when you have time? I'm happy to address any issues if the checks fail. Thanks! |
Author
|
Payout asset: USDC |
Author
|
Payout asset: USDC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
Why:
Issue #2595 reported that the On Volume Trigger only uses extents without accounting for rotation and scale. When a volume trigger is rotated or scaled, overlap detection produces incorrect results. The new \overlap_obb()\ method transforms half-extents by world-space basis vectors (right/up/look) and applies SAT across all 15 separating axes.
Validation:
Risk:
Low. Purely additive change. Existing \overlap()\ behavior preserved. New \overlap_obb()\ only used by volume trigger nodes.