luckfox-lyra-ultra-w: Add spidev overlay with 2 CS#505
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a Luckfox Lyra Ultra W SPI0 spidev overlay with two chip selects, explicit RM_IO pinmux settings, SPI0 enabled, and two spidev child nodes. The overlay README is updated to list the new option and describe it. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@arch/arm/boot/dts/overlay/rockchip-luckfox-lyra-ultra-w-spi0-2cs-spidev.dts`:
- Around line 1-39: The new SPI0 spidev overlay is defined in the DTS but is not
being built because it is missing from the overlay Makefile. Update
arch/arm/boot/dts/overlay/Makefile to add
rockchip-luckfox-lyra-ultra-w-spi0-2cs-spidev.dtbo to the overlay build list so
the new overlay is compiled and shipped, matching the README and the DTS entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 522c9280-8904-4b4e-bdea-ed788705e9d3
📒 Files selected for processing (2)
arch/arm/boot/dts/overlay/README.rockchip-overlaysarch/arm/boot/dts/overlay/rockchip-luckfox-lyra-ultra-w-spi0-2cs-spidev.dts
Adds spidev overlay with 2 chipselect lines for Lyra Ultra, mirroring raspberry-pi placement (Lyra Ultra pinout mirrors the first 26pins of a raspberry pi)
d7ef26f to
1e41300
Compare
Adds spidev overlay with 2 chipselect lines for Luckfox Lyra Ultra, mirroring raspberry-pi placement (Lyra Ultra pinout mirrors the first 26pins of a raspberry pi)