Skip to content

luckfox-lyra-ultra-w: Add spidev overlay with 2 CS#505

Open
vidplace7 wants to merge 1 commit into
armbian:rk-6.1-rkr5.1from
vidplace7:lyra-ultra-spidev-2cs
Open

luckfox-lyra-ultra-w: Add spidev overlay with 2 CS#505
vidplace7 wants to merge 1 commit into
armbian:rk-6.1-rkr5.1from
vidplace7:lyra-ultra-spidev-2cs

Conversation

@vidplace7

Copy link
Copy Markdown
Member

Adds spidev overlay with 2 chipselect lines for Luckfox Lyra Ultra, mirroring raspberry-pi placement (Lyra Ultra pinout mirrors the first 26pins of a raspberry pi)

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bb2d0643-2d62-457f-9270-d4e555c11b80

📥 Commits

Reviewing files that changed from the base of the PR and between d7ef26f and 1e41300.

📒 Files selected for processing (3)
  • arch/arm/boot/dts/overlay/Makefile
  • arch/arm/boot/dts/overlay/README.rockchip-overlays
  • arch/arm/boot/dts/overlay/rockchip-luckfox-lyra-ultra-w-spi0-2cs-spidev.dts
✅ Files skipped from review due to trivial changes (2)
  • arch/arm/boot/dts/overlay/README.rockchip-overlays
  • arch/arm/boot/dts/overlay/Makefile
🚧 Files skipped from review as they are similar to previous changes (1)
  • arch/arm/boot/dts/overlay/rockchip-luckfox-lyra-ultra-w-spi0-2cs-spidev.dts

Walkthrough

Adds a Luckfox Lyra Ultra W SPI0 spidev overlay with two chip selects, explicit RM_IO pinmux settings, SPI0 enabled, and two spidev child nodes. The overlay README is updated to list the new option and describe it.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding a two-CS spidev overlay for Luckfox Lyra Ultra-W.
Description check ✅ Passed The description is related to the change and correctly describes adding a two-chip-select spidev overlay.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@arch/arm/boot/dts/overlay/rockchip-luckfox-lyra-ultra-w-spi0-2cs-spidev.dts`:
- Around line 1-39: The new SPI0 spidev overlay is defined in the DTS but is not
being built because it is missing from the overlay Makefile. Update
arch/arm/boot/dts/overlay/Makefile to add
rockchip-luckfox-lyra-ultra-w-spi0-2cs-spidev.dtbo to the overlay build list so
the new overlay is compiled and shipped, matching the README and the DTS entry.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 522c9280-8904-4b4e-bdea-ed788705e9d3

📥 Commits

Reviewing files that changed from the base of the PR and between 95e85f6 and d7ef26f.

📒 Files selected for processing (2)
  • arch/arm/boot/dts/overlay/README.rockchip-overlays
  • arch/arm/boot/dts/overlay/rockchip-luckfox-lyra-ultra-w-spi0-2cs-spidev.dts

Adds spidev overlay with 2 chipselect lines for Lyra Ultra, mirroring raspberry-pi placement (Lyra Ultra pinout mirrors the first 26pins of a raspberry pi)
@vidplace7 vidplace7 force-pushed the lyra-ultra-spidev-2cs branch from d7ef26f to 1e41300 Compare June 25, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant