Skip to content

arm64: dts: rockchip: fix dynamic dclk for CM3588-NAS#502

Open
rpardini wants to merge 1 commit into
armbian:rk-6.1-rkr5.1from
rpardini:cm3588-backport-dclk-fix-from-fe
Open

arm64: dts: rockchip: fix dynamic dclk for CM3588-NAS#502
rpardini wants to merge 1 commit into
armbian:rk-6.1-rkr5.1from
rpardini:cm3588-backport-dclk-fix-from-fe

Conversation

@rpardini

Copy link
Copy Markdown
Member

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a273c02-4dff-4672-a07a-904157a1eaea

📥 Commits

Reviewing files that changed from the base of the PR and between 64a8171 and 8758a35.

📒 Files selected for processing (1)
  • arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts

Walkthrough

This PR adds a new device-tree configuration block for the display subsystem on the RK3588 FriendlyElec CM3588 NAS board. The change introduces clock wiring by specifying two HDMI PHY PLL clock sources (hdptxphy_hdmi0 and hdptxphy_hdmi1) with their corresponding clock name mappings (hdmi0_phy_pll and hdmi1_phy_pll) to the display subsystem node, enabling proper clock distribution to HDMI display controllers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing dynamic dclk for CM3588-NAS by adding display subsystem clock configuration.
Description check ✅ Passed The description references a specific upstream commit addressing the same fix, confirming it's related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant