arm: dts: add Vanxoak HD-RK3506G-EVB board support#485
Open
SeeleVolleri wants to merge 2 commits into
Open
Conversation
SeeleVolleri
force-pushed
the
rk-6.1-rkr5.1
branch
from
fd67b15 to
f5cf3f3
Compare
SeeleVolleri
force-pushed
the
rk-6.1-rkr5.1
branch
from
f5cf3f3 to
e16e0c3
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds RK3506G Vanxoak HD-RK3506G-EVB support: new board DTS defining model/compatible, chosen/bootargs (FIQ console), fiq_debugger, heartbeat LED, fixed regulators and cpu-supply wiring; SPI‑NAND and 4‑bit MMC configuration; dual RMII Ethernet with MDIO PHY nodes; RNG, SARADC/TSADC, USB PHYs and OTG roles. Registers the DTB in the Rockchip DTB Makefile and adds a DTS overlay that forces vdd_arm to 1.1V, registering that overlay in the overlay Makefile. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SeeleVolleri
force-pushed
the
rk-6.1-rkr5.1
branch
from
e16e0c3 to
8f2fecd
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@arch/arm/boot/dts/rk3506g-vanxoak-hd-rk3506g-evb.dts`:
- Around line 82-90: The device tree models vdd_arm as a fixed regulator (node
vdd_arm / vdd-arm) but the hardware uses a PWM-controlled CPU supply; update the
vdd_arm node to the correct regulator type (e.g., compatible = "regulator-pwm"
or the SoC-specific pwm-regulator driver) and add the required PWM properties
(pwm-controller/phandle, pwm-specifier), along with
regulator-min-microvolt/regulator-max-microvolt, vin-supply and any
enable/boot-on flags appropriate for a dynamic regulator, and ensure the CPU
consumer binding (cpu0 -> vdd_arm) remains pointed at that updated node so CPU
OPP/voltage-scaling works correctly.
- Around line 117-123: The MMC node (&mmc) uses the nonstandard property name
cd-gpio which will be ignored by the MMC binding; replace it with the standard
cd-gpios property and provide the same phandle/args (e.g. &gpio1 RK_PB3
GPIO_ACTIVE_LOW) so the card-detect GPIO is recognized (remove or rename cd-gpio
to cd-gpios in the &mmc node).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 95c8fd36-6788-4a9b-b886-1b134c9c8640
📒 Files selected for processing (2)
arch/arm/boot/dts/Makefilearch/arm/boot/dts/rk3506g-vanxoak-hd-rk3506g-evb.dts
SeeleVolleri
force-pushed
the
rk-6.1-rkr5.1
branch
from
8f2fecd to
1b9250e
Compare
SeeleVolleri
force-pushed
the
rk-6.1-rkr5.1
branch
2 times, most recently
from
d38bf2e to
71363c2
Compare
Add device tree for the Vanxoak HD-RK3506G-EVB V1 board featuring: - Dual RMII Ethernet (GMAC0/GMAC1, clock_in_out=input, 25MHz CLK_MAC_OUT) - SPI-NAND via FSPI - SD card - USB OTG0 (peripheral) + OTG1 (host)
The device defaults shipped with a LDO which only provides 960mV by default (told by vendor support), and it will only activate OPPs up to 1512MHz. This commit adds an overlay to fake the LDO to 1100mV to activate the full OPP table including 1608MHz.
SeeleVolleri
force-pushed
the
rk-6.1-rkr5.1
branch
2 times, most recently
from
773c17d to
eb6022d
Compare
There was a problem hiding this comment.
Pull request overview
Adds Linux device-tree support for the Vanxoak HD-RK3506G-EVB V1 board (RK3506) and a Rockchip DT overlay intended to force-enable all CPU OPP tables by faking the CPU regulator voltage.
Changes:
- Introduce
rk3506g-vanxoak-hd-rk3506g-evb.dtswith peripherals enabled (RMII Ethernet x2, FSPI SPI-NAND, SD, USB OTG roles, ADCs, LED, fixed regulators). - Add a Rockchip overlay
rockchip-vanxoak-hd-rk3506g-evb-all-opp.dtsto overridevdd_armvoltage constraints. - Register the new DTB/DTBO in the corresponding DTS Makefiles.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| arch/arm/boot/dts/rk3506g-vanxoak-hd-rk3506g-evb.dts | New base board DTS enabling key peripherals and defining regulators/LEDs. |
| arch/arm/boot/dts/overlay/rockchip-vanxoak-hd-rk3506g-evb-all-opp.dts | New overlay to fake CPU regulator voltage to allow higher OPPs. |
| arch/arm/boot/dts/overlay/Makefile | Builds the new DTBO. |
| arch/arm/boot/dts/Makefile | Builds the new DTB. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+118
to
+120
| phy-mode = "rmii"; | ||
| clock_in_out = "input"; | ||
| snps,reset-gpio = <&gpio1 RK_PD3 GPIO_ACTIVE_LOW>; |
Comment on lines
+133
to
+135
| phy-mode = "rmii"; | ||
| clock_in_out = "input"; | ||
| snps,reset-gpio = <&gpio1 RK_PD2 GPIO_ACTIVE_LOW>; |
Comment on lines
+151
to
+153
| clocks = <&cru CLK_MAC_OUT>; | ||
| assigned-clocks = <&cru CLK_MAC_OUT>; | ||
| assigned-clock-rates = <25000000>; |
Comment on lines
+161
to
+163
| clocks = <&cru CLK_MAC_OUT>; | ||
| assigned-clocks = <&cru CLK_MAC_OUT>; | ||
| assigned-clock-rates = <25000000>; |
| title = "Enable all CPU OPPs"; | ||
| compatible = "vanxoak,hd-rk3506g-evb", "rockchip,rk3506"; | ||
| category = "misc"; | ||
| description = "Fake vdd_arm LDO to 1100mV to activate all CPU OPPs."; |
Comment on lines
19
to
+21
| rockchip-rk3506-disable-ethernet0.dtbo \ | ||
| rockchip-rk3506-disable-ethernet1.dtbo | ||
| rockchip-rk3506-disable-ethernet1.dtbo \ | ||
| rockchip-vanxoak-hd-rk3506g-evb-all-opp.dtbo |
Contributor
Author
|
Sorry pressed wrong button, not intended to let copilot review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add device tree for the Vanxoak HD-RK3506G-EVB V1 board featuring: