[move][move-ide] Swap move-analyzer to use loc (MystenLabs#18345)

## Description 

This swaps the move analyzer `DefLoc` to be a shared IR `Loc` form (used
everywhere else).

## Test plan 

The move analyzer tests pass, plus local testing in VS Code still works.

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:

external-crates/move/crates/move-analyzer/src/completion.rs

@@ -6,7 +6,7 @@ use crate::{
     context::Context,
     symbols::{
         self, mod_ident_to_ide_string, ret_type_to_ide_str, type_args_to_ide_string,
-        type_list_to_ide_string, type_to_ide_string, DefInfo, DefLoc, PrecompiledPkgDeps,
+        type_list_to_ide_string, type_to_ide_string, DefInfo, PrecompiledPkgDeps,
         SymbolicatorRunner, Symbols,
     },
     utils,
@@ -188,6 +188,7 @@ fn context_specific_lbrace(
             continue;
         };
         if !is_definition(
+            symbols,
             position.line,
             u.col_start(),
             use_file_mod_def.fhash(),
@@ -232,8 +233,7 @@ fn fun_def_info(
     let Some(fdef) = mdef.functions.get(&name) else {
         return None;
     };
-    let def_loc = DefLoc::new(fhash, fdef.start);
-    symbols.def_info(&def_loc)
+    symbols.def_info(&fdef.name_loc)
 }
 
 fn fun_completion_item(
@@ -376,6 +376,7 @@ fn context_specific_no_trigger(
                 break;
             };
             if is_definition(
+                symbols,
                 position.line,
                 u.col_start(),
                 use_file_mod_def.fhash(),
@@ -402,7 +403,7 @@ fn context_specific_no_trigger(
             }
 
             // get module info containing the init function
-            let Some(mdef) = symbols.mod_defs(&u.def_loc().fhash(), *mod_ident) else {
+            let Some(mdef) = symbols.mod_defs(&u.def_loc().file_hash(), *mod_ident) else {
                 break;
             };
 
@@ -440,10 +441,22 @@ fn context_specific_no_trigger(
 }
 
 /// Checks if a use at a given position is also a definition.
-fn is_definition(use_line: u32, use_col: u32, use_fhash: FileHash, def_loc: DefLoc) -> bool {
-    use_fhash == def_loc.fhash()
-        && use_line == def_loc.start().line
-        && use_col == def_loc.start().character
+fn is_definition(
+    symbols: &Symbols,
+    use_line: u32,
+    use_col: u32,
+    use_fhash: FileHash,
+    def_loc: Loc,
+) -> bool {
+    if let Some(use_loc) = symbols
+        .files
+        .line_char_offset_to_loc_opt(use_fhash, use_line, use_col)
+    {
+        // TODO: is overlapping better?
+        def_loc.contains(&use_loc)
+    } else {
+        false
+    }
 }
 
 /// Finds white-space separated strings on the line containing auto-completion request and their

external-crates/move/crates/move-analyzer/src/inlay_hints.rs

@@ -3,7 +3,7 @@
 
 use crate::{
     context::Context,
-    symbols::{on_hover_markup, type_to_ide_string, DefInfo, DefLoc, Symbols},
+    symbols::{on_hover_markup, type_to_ide_string, DefInfo, Symbols},
 };
 use lsp_server::Request;
 use lsp_types::{
@@ -29,10 +29,11 @@ pub fn on_inlay_hint_request(context: &Context, request: &Request, symbols: &Sym
         if let Some(file_defs) = symbols.file_mods.get(&fpath) {
             for mod_defs in file_defs {
                 for untyped_def_loc in mod_defs.untyped_defs() {
+                    let start_position = symbols.files.start_position(untyped_def_loc);
                     if let Some(DefInfo::Local(n, t, _, _)) = symbols.def_info(untyped_def_loc) {
                         let position = Position {
-                            line: untyped_def_loc.start().line,
-                            character: untyped_def_loc.start().character + n.len() as u32,
+                            line: start_position.line_offset() as u32,
+                            character: start_position.column_offset() as u32 + n.len() as u32,
                         };
                         let colon_label = InlayHintLabelPart {
                             value: ": ".to_string(),
@@ -106,8 +107,7 @@ fn additional_hint_info(sp!(_, t): &N::Type, symbols: &Symbols) -> Option<InlayH
         return None;
     };
 
-    let struct_def_loc = DefLoc::new(mod_defs.fhash(), struct_def.name_start());
-    let Some(struct_def_info) = symbols.def_info(&struct_def_loc) else {
+    let Some(struct_def_info) = symbols.def_info(&struct_def.name_start()) else {
         return None;
     };