Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mage tests instead of make tests #2861

Merged
merged 1 commit into from
Aug 9, 2023
Merged

add mage tests instead of make tests #2861

merged 1 commit into from
Aug 9, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Aug 9, 2023

Add mage tests instead of make tests.

Verify codecov works correctly in new path.

And also fix any tests that this added.

┆Issue is synchronized with this Jira Task by Unito

@kannon92 kannon92 requested a review from Sharpz7 August 9, 2023 16:11
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +30.79% 🎉

Comparison is base (ad5bcc7) 16.21% compared to head (dc27631) 47.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2861       +/-   ##
===========================================
+ Coverage   16.21%   47.01%   +30.79%     
===========================================
  Files         160      391      +231     
  Lines       12559    43055    +30496     
  Branches      487      487               
===========================================
+ Hits         2037    20244    +18207     
- Misses      10353    21291    +10938     
- Partials      169     1520     +1351     
Flag Coverage Δ
unittests 47.01% <ø> (+30.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 231 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sharpz7
Copy link
Contributor

Sharpz7 commented Aug 9, 2023

LGTM

@kannon92 kannon92 merged commit 510d59b into master Aug 9, 2023
32 checks passed
@kannon92 kannon92 deleted the mage-tests branch August 9, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants